3-verify-pr-fix

Verify a candidate PR

Review the packet, the candidate diff, and relevant tests. Live comparison against a captured baseline is optional. No edits, no merges, no pushes.

1. Resolve the PR and its linked issue

PR=$(echo "$ARGUMENTS" | sed -E 's|.*/||; s|#||g' | grep -oE '^[0-9]+' | head -1)
[ -z "$PR" ] && { echo "Invalid input: '$ARGUMENTS'. Pass a PR number or URL." >&2; exit 1; }
REPO=stickerdaniel/linkedin-mcp-server

gh pr view $PR --repo $REPO --json title,body,baseRefName,headRefName,headRepositoryOwner,mergeable,mergeStateStatus,additions,deletions,changedFiles,maintainerCanModify,statusCheckRollup

Extract the linked issue number from the PR body (Closes #, Fixes #, Resolves #, or plain #N). Call it ISSUE. If multiple, ask which one is the verification target.

Read that issue's packet and comments.

2. Packet, diff, and tests

This path does not need /tmp/repro-issue-$ISSUE-main.json. Absence of a local baseline limits the live branch, not the whole PR verdict. Do not create fake success or failure files.

gh pr diff $PR --repo $REPO
gh pr view $PR --repo $REPO --json files --jq '.files[].path'

Hard flags (any one downgrades a clean live pass to concerns):

• Locale-dependent detection: == "Connect", in ["Pending", "Follow"], contains("1st"), aria-label="..." with translated text. Attribute presence is the locale-independent signal.
• LinkedIn class-name selectors: .entity-result__item, .artdeco-button__text. Minimal generic selectors only (a[href*="/jobs/view/"]).
• Multiple navigations behind one PERSON_SECTIONS / COMPANY_SECTIONS entry.
• Missing tests beside the canonical owner from docs/linkedin-architecture.md.

A supplied capture or regression fixture can support a before-and-after claim within its scope. Protocol or startup failures are execution limits, not a pass.

This step is complete when the report can say whether the diff addresses the packet at this SHA, which audit flags apply, and whether a live comparison is still needed.

3. Optional live comparison

Only after an explicit yes, and only when a genuine captured baseline exists.

/2-repro-issue writes:

• /tmp/repro-issue-<ISSUE>-main.json. Captured response
• /tmp/repro-issue-<ISSUE>-meta.json. {tool, arguments, sha}

If either file is missing or empty, keep the packet-and-diff verdict. Offer the evidence-and-code path. A new live baseline requires approval.